D19989: Unmounting busy device doesn't tell who is blocking

[David Hallas]

hallas added inline comments.

INLINE COMMENTS

> placesitemmodel.cpp:484
>  
> +void PlacesItemModel::queryBlockingApps(const QString& devicePath)
> +{

I just copied this code from the Device Notifier, but it would be nice to have this as general functionality somewhere

> placesitemmodel.cpp:529
> +                } else {
> +                    errorString = i18np("One or more files on this device are opened in application \"%2\".",
> +                            "One or more files on this device are opened in following applications: %2.",

What do you think about the wording of these error messages? Currently I just copied the ones from the Device Notifier, but actually I think that it should also state that unmounting has filed, or maybe that Removal has failed.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19989

To: hallas, #dolphin, elvisangelaccio, ngraham, broulik
Cc: kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190323/16240147/attachment.htm>