D19926: Add Bookmark Handling

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Nice stuff!
  
  In D19926#435383 <https://phabricator.kde.org/D19926#435383>, @hallas wrote:
  
  > Currently I placed the 'Bookmarks' menu under the 'Go' menu, is that a good idea? Should it be a top level menu as it is in Konqueror and Konsole?
  
  
  What about putting it under `Tools`?

INLINE COMMENTS

> dolphinbookmarkhandler.cpp:37
> +        bookmarksFile = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation)
> +                + QStringLiteral("/dolphin");
> +        QDir().mkpath(bookmarksFile);

Prefer `QLatin1String` for concatenation.

Or we could do `QStringliteral("%1/dolphin").arg(QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation))`

> dolphinbookmarkhandler.h:53-54
> +private:
> +    DolphinMainWindow* m_mainWindow_;
> +    QScopedPointer<KBookmarkMenu> bookmarkMenu_;
> +};

Why the trailing underscore?

> dolphinui.rc:2
>  <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
>  <kpartgui name="dolphin" version="21">
>      <MenuBar>

Please bump the version

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19926

To: hallas, #dolphin, elvisangelaccio, ngraham
Cc: kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190320/13a12939/attachment.htm>