D19901: Fixes #399430 - Dolphin: Places: Regression: Move items up/down not working properly

Tigran Gabrielyan noreply at phabricator.kde.org
Wed Mar 20 05:11:52 GMT 2019


tigrang created this revision.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
tigrang requested review of this revision.

REVISION SUMMARY
  `m_sourceModel->movePlace` is called using index from the view model. 
  This becomes an issue when there are hidden places items.
  
  This change calls `m_sourceModel->movePlace` using the corresponding mapped source index.

TEST PLAN
  1. Create at least 4 Places items
  2. Hide first item
  3. Drag the now first visible item between second and third item
  
  Actual: The item does not move
  Expected: The first visible item should now be second visible item in the list

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19901

AFFECTED FILES
  src/panels/places/placesitemmodel.cpp

To: tigrang
Cc: kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190320/b3ee3869/attachment.htm>


More information about the kfm-devel mailing list