D19782: Allow dolphin to auto play previewed media file

Méven Car noreply at phabricator.kde.org
Mon Mar 18 13:25:52 GMT 2019


meven added a subscriber: ngraham.
meven added a comment.


  In D19782#433582 <https://phabricator.kde.org/D19782#433582>, @ngraham wrote:
  
  > This doesn't compile:
  >
  >   [ 70%] Building CXX object src/CMakeFiles/dolphinstatic.dir/dolphin_generalsettings.cpp.o
  >   /home/nate/kde/src/dolphin/src/panels/information/informationpanel.cpp: In member function ‘void InformationPanel::showContextMenu(const QPoint&)’:
  >   /home/nate/kde/src/dolphin/src/panels/information/informationpanel.cpp:182:65: error: ‘previewsAutoplay’ is not a member of ‘InformationPanelSettings’
  >        previewAutoPlayAction->setChecked(InformationPanelSettings::previewsAutoplay());
  >                                                                    ^~~~~~~~~~~~~~~~
  >   /home/nate/kde/src/dolphin/src/panels/information/informationpanel.cpp:224:35: error: ‘setPreviewsAutoplay’ is not a member of ‘InformationPanelSettings’
  >            InformationPanelSettings::setPreviewsAutoplay(isChecked);
  >                                      ^~~~~~~~~~~~~~~~~~~
  >   make[2]: *** [src/CMakeFiles/dolphinstatic.dir/build.make:853: src/CMakeFiles/dolphinstatic.dir/panels/information/informationpanel.cpp.o] Error 1
  >
  >
  > Please make sure to test your code before updating the diff :)
  
  
  I had modified locally the ignored files generated instead of editing the kcfg file, qt-creator hides those files by default.
  Sorry about that.
  This is fixed.
  
  I did the rewording you suggested.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19782

To: meven, #dolphin, elvisangelaccio
Cc: ngraham, broulik, kfm-devel, pekkah, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190318/ac188e4f/attachment.htm>


More information about the kfm-devel mailing list