D19782: Allow dolphin to auto play previewed media file

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This doesn't compile:
  
    [ 70%] Building CXX object src/CMakeFiles/dolphinstatic.dir/dolphin_generalsettings.cpp.o
    /home/nate/kde/src/dolphin/src/panels/information/informationpanel.cpp: In member function ‘void InformationPanel::showContextMenu(const QPoint&)’:
    /home/nate/kde/src/dolphin/src/panels/information/informationpanel.cpp:182:65: error: ‘previewsAutoplay’ is not a member of ‘InformationPanelSettings’
         previewAutoPlayAction->setChecked(InformationPanelSettings::previewsAutoplay());
                                                                     ^~~~~~~~~~~~~~~~
    /home/nate/kde/src/dolphin/src/panels/information/informationpanel.cpp:224:35: error: ‘setPreviewsAutoplay’ is not a member of ‘InformationPanelSettings’
             InformationPanelSettings::setPreviewsAutoplay(isChecked);
                                       ^~~~~~~~~~~~~~~~~~~
    make[2]: *** [src/CMakeFiles/dolphinstatic.dir/build.make:853: src/CMakeFiles/dolphinstatic.dir/panels/information/informationpanel.cpp.o] Error 1
  
  Please make sure to test your code before updating the diff :)

INLINE COMMENTS

> informationpanel.cpp:179
>  
> +    QAction* previewAutoPlayAction = popup.addAction(i18nc("@action:inmenu", "Preview autoPaly"));
> +    previewAutoPlayAction->setIcon(QIcon::fromTheme(QStringLiteral("media-playback-start")));

Typo.

Also, I would re-word to say "Auto-play"

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19782

To: meven, #dolphin, elvisangelaccio, ngraham
Cc: ngraham, broulik, kfm-devel, pekkah, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190318/19eac71d/attachment.htm>