D19782: Allow dolphin to auto play previewed media file after a 1 second delay

Méven Car noreply at phabricator.kde.org
Sat Mar 16 11:14:30 GMT 2019


meven marked an inline comment as done.
meven added inline comments.

INLINE COMMENTS

> broulik wrote in phononwidget.cpp:75
> Add a context `this` or else it will crash when timer fires with the widget being gone:
> 
>   connect(m_autoPlayTimer, &QTimer::timeout, this, [this]() {
> 
> You can also probably just connect to `&PhononWidget::play` directly without a lambda

Thanks I thought I could not use this as context in a connect.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19782

To: meven, #dolphin
Cc: broulik, kfm-devel, pekkah, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190316/1faa8141/attachment.htm>


More information about the kfm-devel mailing list