D19780: Refactor the Information Panel, fixing bugs

Anthony Fieroni noreply at phabricator.kde.org
Fri Mar 15 13:56:12 GMT 2019


anthonyfieroni added inline comments.

INLINE COMMENTS

> informationpanel.cpp:167
>  {
> -    // TODO: Move code from InformationPanelContent::configureSettings() here
> -    m_content->configureSettings(customContextMenuActions(), event->globalPos());
> +    QMenu popup(this);
> +

Do not parent object on the stack, if its parent gets destroyed before, destructor will be called twice.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19780

To: meven, #dolphin
Cc: anthonyfieroni, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190315/e68fd744/attachment.htm>


More information about the kfm-devel mailing list