D19767: Fix malloc/delete mismatch

David Hallas noreply at phabricator.kde.org
Thu Mar 14 19:06:58 GMT 2019


hallas created this revision.
hallas added a reviewer: Frameworks.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
hallas requested review of this revision.

REVISION SUMMARY
  Fixes pointer was allocated with malloc (by libssh) but freed with
  delete. This is not safe and causes undefined behavior.

TEST PLAN
  Build and run kio_sftp with address sanitizer

REPOSITORY
  R320 KIO Extras

BRANCH
  fix_malloc_delete_mismatch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19767

AFFECTED FILES
  sftp/kio_sftp.cpp

To: hallas, #frameworks
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190314/d3c73b33/attachment.htm>


More information about the kfm-devel mailing list