D19696: Add blender thumbnailer

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> blendercreator.cpp:67
> +    QPointer<KCompressionDevice> gzFile;
> +    if(file.peek(2).startsWith("\x1F\x8B")) { // gzip magic (each gzip member starts with ID1(0x1f) and ID2(0x8b))
> +        file.close();

This requires a comment, stating gzip compression is optional.

> blendercreator.cpp:85
> +
> +    // Example header: "BLENDER-257"
> +

Still wrong, "BLENDER-v257", missing 'v'/'V'

> blendercreator.cpp:105
> +    if(isLittleEndian) {
> +        blendStream.setByteOrder(QDataStream::LittleEndian);
> +    } else {

Not relevant, as you only read using `readRawData()`

> blendercreator.cpp:110
> +
> +    auto toInt32 = [isLittleEndian](const QByteArray &bytes) -> qint32 {
> +        return isLittleEndian ? qFromLittleEndian<qint32>(bytes.constData())

Coding style, no trailing return type.

> chinmoyr wrote in blendercreator.cpp:134
> I am trying to swap bgr to rgb here.

So does the code I linked to. No need to cook your own.

REPOSITORY
  R373 Image Thumbnailers

REVISION DETAIL
  https://phabricator.kde.org/D19696

To: chinmoyr, #frameworks, bruns
Cc: bruns, ngraham, broulik, ltoscano, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190313/addd19b2/attachment.htm>