D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

Dominik Haumann noreply at phabricator.kde.org
Sun Mar 10 20:40:55 GMT 2019


dhaumann added inline comments.

INLINE COMMENTS

> kossebau wrote in textcreator.cpp:169
> For the thumbnail the code is rendering on a paper-like canvas, which is hard-coded as well (see lines above with `QColor ( 245, 245, 245 ); // light-grey background`). To simulate a print-out, for what I guess or would have done myself.
> So with that using also a hard-coded theme should be fine, or?

Ah, I thought in a dark color theme the preview is also dark - which does not seem to be the case...

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19432

To: kossebau, broulik, cfeck
Cc: dhaumann, vkrause, cfeck, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190310/abe3e008/attachment.htm>


More information about the kfm-devel mailing list