D18915: Fix batchrename changing extension to lower case

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> bruns wrote in batchrenamejob.cpp:165
> `QString extension = GetFileExtension(url.fileName());`
> ...
> `static QString BatchRenameJobPrivate::GetFileExtension(QString filename)`

Function/method names are usually lowercase. Also, we don't add `get` for getters, only `set` for setters.

⇒ `fileExtension()` ?

Additionally, we pass QString via reference

⇒ `QString &filename` ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: cfeck, bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190308/a4463517/attachment.htm>