D19243: Allow the FileMetaDataConfigWidget to emit a loadedMetadata signal when its metadata has been loaded, and adjust its size based on its content

[Méven Car]

meven added a comment.


  In D19243#425594 <https://phabricator.kde.org/D19243#425594>, @bruns wrote:
  
  > Can you **please** try `updateGeometry()` instead of adding a proprietary signal?
  
  
  Of course, no need to implore me, I learn as I go thanks to the review process.
  I missed the first mention of updateGeometry.
  Thanks for pointing it out again :)
  
  > The custom sizeHint() code indeed seems to be necessary, as although the scroll area view-container calculates the content size (otherwise the scrollbars would not work) it does not propagate it to its own sizeHint().
  
  According to my testing the original sizeHint() returns a constant regardless of its content.

INLINE COMMENTS

> ngraham wrote in filemetadataconfigwidget.cpp:203
> Better to read the actual text metrics rather than assuming a height. Something like this:
> 
>   const QFontmetrics metrics(d->m_metaDataList->font())
>   const int lineHeight = metrics.height()

Thanks, I am not too familiar with the Kde/Qt API, this was a question in the related change https://phabricator.kde.org/D19241

But the suggested line height is too low.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D19243

To: meven, #dolphin, #baloo, ngraham
Cc: bruns, elvisangelaccio, ngraham, #baloo, gennad, domson, ashaposhnikov, astippich, spoorun, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190306/5edbdab1/attachment.htm>