D19241: Show the FileMetaDataConfigurationDialog dialog only after its widget has emmitted metadataLoaded signal

Méven Car noreply at phabricator.kde.org
Tue Mar 5 16:50:53 GMT 2019


meven marked an inline comment as done.
meven added inline comments.

INLINE COMMENTS

> ngraham wrote in informationpanelcontent.cpp:306
> A slightly more direct approach might be to listen for the `metadataLoaded` signal here, and then hook it up to `show()` in a lambda function, if that works.

I have replaced this with a signal/slot to let the InformationPanelContent displays the dialog once ready.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19241

To: meven, #dolphin, elvisangelaccio
Cc: elvisangelaccio, ngraham, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190305/7e33b1dd/attachment.htm>


More information about the kfm-devel mailing list