D19241: Show the FileMetaDataConfigurationDialog dialog only after its widget has emmitted metadataLoaded signal

[Méven Car]

meven added a comment.


  
  
  In D19241#418209 <https://phabricator.kde.org/D19241#418209>, @elvisangelaccio wrote:
  
  > > Is the design of letting dialog choosing when to show up ok ?
  >
  > Please don't, a `QDialog` is supposed to be shown by using `show()` or `open()`, it shouldn't open on its own.
  
  
  Do you have an alternative design here : The dialog must be shown only after it's content has been asynchronously loaded.
  
  The alternative I can see is to let the caller wait to display the dialog until it is ready the display signals it is ready.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19241

To: meven, #dolphin, elvisangelaccio
Cc: elvisangelaccio, ngraham, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190305/006c2330/attachment.htm>