D19201: New tab placed after current tab when middle-clicking

[David Hallas]

hallas marked an inline comment as done.
hallas added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in dolphinmainwindow.cpp:1330
> We are going to use this lambda in 3 different places. Maybe this calls for a new `openNewTabAfterCurrentTab()` private slot.

I have create dedicated functions for both cases and use them throughout this class.

> elvisangelaccio wrote in dolphinpart.cpp:97
> Why this change? We are not using the `TabPlacement` argument here, anyway

This change has been reverted :)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19201

To: hallas, #dolphin, ngraham, elvisangelaccio
Cc: kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190303/1f5d0661/attachment.htm>