D18838: Fix opening http links in browser

David Faure noreply at phabricator.kde.org
Sat Mar 2 23:38:00 GMT 2019


dfaure added inline comments.

INLINE COMMENTS

> dolphinviewcontainer.cpp:661
> +
> +            if (browser.startsWith(QLatin1Char('!'))) {
> +                // Literal command

Err why all this code here?
This is KRun's job.

Why not just use KRun here? For instance KRun::runUrl.

Or is the problem that KRun pops up message boxes? We need to make that configurable then, instead of duplicating the various cases for BrowserApplication.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D18838

To: broulik, #dolphin, dfaure
Cc: elvisangelaccio, ngraham, ltoscano, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190302/8b658a85/attachment.htm>


More information about the kfm-devel mailing list