D19201: New tab placed after current tab when middle-clicking

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> dolphinmainwindow.cpp:1330
>      connect(foldersPanel, &FoldersPanel::folderMiddleClicked,
> -            this, &DolphinMainWindow::openNewTab);
> +            this, [this](const QUrl& url) { this->openNewTab(url, DolphinTabWidget::AfterCurrentTab); });
>      connect(foldersPanel, &FoldersPanel::errorMessage,

We are going to use this lambda in 3 different places. Maybe this calls for a new `openNewTabAfterCurrentTab()` private slot.

> dolphinpart.cpp:97
>      connect(m_view, &DolphinView::tabRequested,
> -            this, &DolphinPart::createNewWindow);
> +            this, [this](const QUrl& url, DolphinTabWidget::TabPlacement) { this->createNewWindow(url); });
>      connect(m_view, &DolphinView::requestContextMenu,

Why this change? We are not using the `TabPlacement` argument here, anyway

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19201

To: hallas, #dolphin, ngraham, elvisangelaccio
Cc: kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190302/b70cc1c0/attachment.htm>