D22149: Add "Add to Places" action to file menu

Nathaniel Graham noreply at phabricator.kde.org
Fri Jun 28 20:38:31 BST 2019


ngraham created this revision.
ngraham added a reviewer: Dolphin.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  It's recommended that actions available in context menus be available in the main menu
  as well for discoverability's sake. This patch does so for the "Add to Places" action.
  
  The action is moved over to the main window, and accessed in the context meny via the
  actionCollection it lives in.
  
  BUG: 390757
  FIXED-IN: 19.08.0

TEST PLAN
  - Action still works
  - Action still appears in context menu when relevant
  - Action in the File menu only becomes enabled when on;y a single directory is selected

REPOSITORY
  R318 Dolphin

BRANCH
  add-to-places-in-file-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22149

AFFECTED FILES
  src/dolphincontextmenu.cpp
  src/dolphinmainwindow.cpp
  src/dolphinmainwindow.h
  src/dolphinui.rc

To: ngraham, #dolphin
Cc: kfm-devel, fprice, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190628/2a44fc59/attachment.htm>


More information about the kfm-devel mailing list