D21937: Use destinationDir to save viewproperties when not in global viewproperties setting

Nathaniel Graham noreply at phabricator.kde.org
Thu Jun 20 23:44:37 BST 2019


ngraham added inline comments.

INLINE COMMENTS

> viewproperties.cpp:89
> +            const QString oldViewPropertyFile = url.toLocalFile() + QDir::separator() + ViewPropertiesFileName;
> +            const QString newViewPropertyFile = m_filePath + QDir::separator() + ViewPropertiesFileName;
> +

Don't use `QDir::separator()`; Qt automatically translates slashes as needed on Windows.

https://agateau.com/2015/qdir-separator-considered-harmful/

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D21937

To: meven, ngraham, elvisangelaccio, #dolphin
Cc: kfm-devel, fprice, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190620/9ae4525a/attachment.htm>


More information about the kfm-devel mailing list