D21937: Use destinationDir to save viewproperties when not in global viewproperties setting
Nathaniel Graham
noreply at phabricator.kde.org
Thu Jun 20 22:53:56 BST 2019
ngraham added a comment.
This should make a lot of people happy. :) But what happens when a folder is moved?
INLINE COMMENTS
> viewproperties.cpp:84
>
> - if (m_filePath == QStandardPaths::writableLocation(QStandardPaths::DownloadLocation)) {
> - useDownloadsView = true;
> + // In case the viewproperty file was not located in destinationDir already prior to fix to 322922
> + // After a few version we can remove this code block and most users won't be affected anymore by the change
`prior to fix to 322922` -> `prior to fixing 322922`
> viewproperties.cpp:85
> + // In case the viewproperty file was not located in destinationDir already prior to fix to 322922
> + // After a few version we can remove this code block and most users won't be affected anymore by the change
> + if (!usedToUseDestinationDir) {
`version` -> `versions`
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D21937
To: meven, ngraham, elvisangelaccio, #dolphin
Cc: kfm-devel, fprice, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190620/eb2aa7ef/attachment.htm>
More information about the kfm-devel
mailing list