D21789: Fix tests relating to the removal of the Root Place in D15739

Méven Car noreply at phabricator.kde.org
Tue Jun 18 12:10:30 BST 2019


meven added a comment.


  In D21789#480922 <https://phabricator.kde.org/D21789#480922>, @elvisangelaccio wrote:
  
  > I'd avoid to bump the KF5 version only because of a test.
  >
  > What we can do instead is to add the following check in `src/tests/CMakeLists.txt` :
  >
  >   if (KIO_VERSION VERSION_GREATER_EQUAL "5.60.0")
  >       ecm_add_test(placesitemmodeltest.cpp ...)
  >   endif()
  >
  
  
  This is done, will wait for approval here before merging in KIO D15739 <https://phabricator.kde.org/D15739>.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D21789

To: meven, elvisangelaccio, ngraham
Cc: kfm-devel, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190618/9f423290/attachment.htm>


More information about the kfm-devel mailing list