D21590: Fix rubber band not going away after right-click

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kitemlistcontroller.cpp:603-605
> +        disconnect(rubberBand, &KItemListRubberBand::endPositionChanged, this, &KItemListController::slotRubberBandChanged);
> +        rubberBand->setActive(false);
> +        m_view->setAutoScroll(false);

Please wrap this code within `if (rubberBand->isActive()) { ... }`

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D21590

To: jacksonmcneill, #dolphin, ngraham, elvisangelaccio
Cc: elvisangelaccio, ngraham, kfm-devel, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190616/a2aef670/attachment.htm>