D21691: Open new instance of Dolphin if no URLs are given

Elvis Angelaccio noreply at phabricator.kde.org
Mon Jun 10 21:19:26 BST 2019


elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> global.cpp:76
> +    if (KWindowSystem::isPlatformWayland() || inputUrls.isEmpty()) {
>          // TODO: once Wayland clients can raise or activate themselves remove this conditional
>          return false;

Please move this TODO comment above the if() block, since now it's not about the `return false` but just the wayland check.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D21691

To: feverfew, ngraham, elvisangelaccio
Cc: elvisangelaccio, ngraham, kfm-devel, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190610/a16a64ae/attachment.htm>


More information about the kfm-devel mailing list