D21573: Scroll when pressing PageUp/PageDown

Tranter Madi noreply at phabricator.kde.org
Tue Jun 4 09:59:47 BST 2019


trmdi created this revision.
trmdi added reviewers: Dolphin, Zren, cfeck.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  Add `PageUp/PageDown` to the `navigationPressed` variable.
  Remove the `m_view->firstVisibleIndex()` and `m_view->lastVisibleIndex()` tests because sometimes it does not work correctly.
  
  BUG: 407118

TEST PLAN
  Press PageUp/PageDOwn: it scrolls
  Press Up/DOwn: it always scrolls

REPOSITORY
  R318 Dolphin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21573

AFFECTED FILES
  src/kitemviews/kitemlistcontroller.cpp

To: trmdi, #dolphin, Zren, cfeck
Cc: kfm-devel, LeGast00n, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190604/903759f0/attachment.htm>


More information about the kfm-devel mailing list