D22144: Add kio recentlyused:/ to access KActivityStats data

[Méven Car]

meven marked 2 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> ivan wrote in recentlyused.cpp:140-144
> Could this just be replaced with `query = query | Agent(agentValue.split(QLatin1Char(',')));`?
> 
> Obviously, the downside is always creating a list (usually with a single item in it), the upside is that it does not need to traverse the string twice (once to chech for commas, and the second time to split the string.
> 
> The trade-off depends on internals of Qt - if  you don't have the time to benchmark what is faster, leave it as is.

I have used count() as it allows not to keep the list in memory if not needed.
Same was done for the type parameter.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190724/0a4af6f7/attachment.htm>