D22105: WIP : Fix SFTP Plugin of KIO for Windows

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kio_sftp.cpp:2028
>          }
> -        else if (QT_STAT( QFile::encodeName(sPart), &buff ) == 0) { // should a very small ".part" be deleted?
> +        else if (partFile.exists()) { // should a very small ".part" be deleted?
>              const int size = config()->readEntry("MinimumKeepSize", DEFAULT_MINIMUM_KEEP_SIZE);

Better not do refresh on success, it slows things down for no purpose.

  else {
      partFile.refresh();
      const int size = ...;
      if (partFile.exists() && partFile.size() < size) {
          partFile.remove();
      }
  }

> kio_sftp.cpp:2045
> +                }
> +                else {
> +                    receivedFile.setFileTime(dt, QFileDevice::FileModificationTime);

coding style: join with previous line

  } else {

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22105

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190721/d28fb1a2/attachment.htm>