D22594: [Dolphin] Open Preferred Search Tool action

[Piotr Dabrowski]

pdabrowski added a comment.


  > The way you've implemented the menu item naming seems a bit fragile though
  
  True. It's really hard to update it reliably.
  KMoreTools* do not provide an easy way to get notified that the tools changed. Even current solution in "More Search Tools" menu recreates the menu every time it is displayed.
  So I tried updating the action every time menu containing it is shown. Connect()ions for this aren't pretty, but this should actually work...
  
  > In my testing, the name doesn't show up and it falls back to the static name.
  
  This is strange, because this action should be updated on many occasions, including Dolphin startup.
  Or is your testcase installing KFind while Dolphin is open, or doing something similar? (Either way, that should work too).
  
  Please let me know a test scenario that fails.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22594

To: pdabrowski, #dolphin, ngraham, elvisangelaccio
Cc: kfm-devel, kde-doc-english, aprcela, fprice, gennad, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, skadinna, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190721/ca7a707d/attachment.htm>