D22105: WIP : Fix SFTP Plugin of KIO for Windows

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> kio_sftp.cpp:2047
> +                    QString error_msg = receivedFile.errorString();
> +                    qDebug() << QStringLiteral("Couldn't update modified time : ") << error_msg;
> +                }

no need for QStringLiteral here, sending a `const char *` to debug is perfectly fine; also, the qDebug must be categorized, just like all the other debug outputs

> kio_sftp.cpp:2050-2051
> +                else {
> +                    // receivedFile.setFileTime(QDateTime::fromTime_t(buff.st_atime),
> +                    //                         QFileDevice::FileTime(QFileDevice::FileAccessTime));
> +                    receivedFile.setFileTime(dt, QFileDevice::FileTime(QFileDevice::FileModificationTime));

what is this commented code for?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22105

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190721/d5a6858f/attachment.htm>