D22105: WIP : Fix SFTP Plugin of KIO for Windows

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kio_sftp.cpp:1946
>      // check if destination is ok ...
>      QT_STATBUF buff;
> +    QFileInfo copyFile(sCopyFile);

Please remove this variable, since you're not calling QT_STAT anymore.

You'll notice that you're still using buff.st_size, which should become QFileInfo's size() method instead...

> kio_sftp.cpp:1973
>          }
>          bResume = canResume( buff.st_size );
>      }

Red alert! Red alert! Uninitialized data being used!

> kio_sftp.cpp:2067
>      // check if source is ok ...
>      QT_STATBUF buff;
> +    QFileInfo copyFile(sCopyFile);

Same here

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22105

To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190720/32cb13e8/attachment.htm>