D17595: Upstream Dolphin's file rename dialog

David Faure noreply at phabricator.kde.org
Sat Jul 20 11:07:55 BST 2019


dfaure added inline comments.

INLINE COMMENTS

> renamefiledialog.cpp:59
> +    KFileItemList items;
> +    bool allExtensionsDifferent;
> +    QSpinBox* spinBox;

group the bools together for less padding

> meven wrote in renamefiledialog.cpp:60
> I really wish we would enforce use of a code formater, community wise ...
> This is something I miss from rust:  `cargo fmt`
> Such as astyle.

Just run `uncrustify-kf5` from the repo kde-dev-scripts.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham
Cc: dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190720/e523a463/attachment.htm>


More information about the kfm-devel mailing list