D17595: Upstream Dolphin's file rename dialog

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> renamefiledialog.h:72
> +protected:
> +    void showEvent(QShowEvent* event) override;
> +

You'll also want to override `event` as per https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B

> renamefiledialog.h:75
> +private:
> +    class RenameFileDialogPrivate;
> +    RenameFileDialogPrivate *const d;

This is now forward declared twice.

> renamefiledialog.h:76
> +    class RenameFileDialogPrivate;
> +    RenameFileDialogPrivate *const d;
> +};

You can in fact make the class forward declaration and the member declaration one line

`class RenameFileDialogPrivate *const d;`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham
Cc: sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, pino, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190719/8d23ef30/attachment.htm>