D22303: Fix name grouping feature for cyrillic names

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
elvisangelaccio added a comment.


  In D22303#492247 <https://phabricator.kde.org/D22303#492247>, @AndreyYashkin wrote:
  
  > In D22303#491971 <https://phabricator.kde.org/D22303#491971>, @elvisangelaccio wrote:
  >
  > > Thanks for the patch!
  > >
  > > Given that the correctness of this code depends on the locale, I'm not confident we won't break some corner cases. 
  > >  Ideally we'd need more unit tests in `KFileItemModelTest::testNameRoleGroups()`, but I understand that's a lot to ask.
  > >
  > > @cfeck in the bug report suggested to add more letters ranges. @AndreyYashkin Did you try that?
  >
  >
  > As I understand the puprose of vector "lettersAtoZ" is to put words like "Ottava" and german "Österreich" in one latin "O" group. It seems to be some feature of german language that was taken into account by the author of code. I cannot speak for all who use cyrillic script, but in russian we do not expect anything like this. Thatwhy I discarded the idea of one more range. In addition, it may be wrong to apply such behavior for all languages that use extended latin alphabets.
  >
  > QCollator thinks that cyrillic symbols are less than latin characters, while chinese and others are bigger. For this reason, it is necessary to put them in a new group without searching them in the vector or they will be putted in latin "A" group.
  
  
  I see. I'd say let's push this patch and let's wait for feedback from 19.08 beta users.
  
  You don't have commit access, do you? What's the email address we should use for the git autorship?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22303

To: AndreyYashkin, #dolphin, ngraham, cfeck, elvisangelaccio
Cc: cfeck, ngraham, elvisangelaccio, kfm-devel, aprcela, fprice, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190717/8664d3ae/attachment.htm>