D22183: Add click to play/play feature on previews for audio/video

Méven Car noreply at phabricator.kde.org
Wed Jul 17 10:27:36 BST 2019


meven added a comment.


  I have update the code to reflect an issue with the positioning in Hdpi cases.
  
  I feel the arrow is not very satisfying eye-candy wise, but I have little QPainter experience to make it look better.
  So I feel it can land but we should improve on the situation later.
  
  Btw should it land in 19.08 ?

INLINE COMMENTS

> shubham wrote in phononwidget.cpp:101
> use qobjectcast

QEvent does not inherit QObject : qobject_cast can't be used to cast its instances.

REPOSITORY
  R318 Dolphin

BRANCH
  arcpatch-D22183

REVISION DETAIL
  https://phabricator.kde.org/D22183

To: meven, elvisangelaccio, #dolphin, ngraham
Cc: shubham, anthonyfieroni, ngraham, kfm-devel, aprcela, fprice, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190717/dbdc825f/attachment.htm>


More information about the kfm-devel mailing list