D22386: Fix an issue with a new tab focus

[Andrey Yashkin]

AndreyYashkin added a comment.


  In D22386#495914 <https://phabricator.kde.org/D22386#495914>, @anthonyfieroni wrote:
  
  > It does not look correct either, the problem is that the focus on location bar is delayed and setActive(false) isn't applied, this is workaround. But we have problems on that before, exactly that part with focusIn on location bar. You should correct there but it can break something other.
  
  
  When tab is switched, //DolphinTabWidget::currentTabChanged// deactivates last-viewed tab page and activates new current tab, and there should be only one active tab at same moment. The problem is that //DolphinTabWidget::openNewTab// creates tabs in active state and now there several tabs in active state, which don't get the focus on the files view after switching on them first time, because //DolphinView::setActive// doesn't do anything if new active state(true) is equal to old state(true), while it should set focus on the view.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22386

To: AndreyYashkin, #dolphin, ngraham, elvisangelaccio
Cc: anthonyfieroni, ngraham, elvisangelaccio, kfm-devel, aprcela, fprice, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190716/878c5c41/attachment.htm>