D22444: Add zoom reset action

Nathaniel Graham noreply at phabricator.kde.org
Mon Jul 15 20:49:48 BST 2019


ngraham added a comment.


  Cool, it works and the code is looking pretty good. Now I think the new action needs to be added to the View menu too, between the zoom in and zoom out menu items. The place where you've added it in `dolphinui.rc` doesn't actually do that.

INLINE COMMENTS

> dolphinviewactionhandler.cpp:193
> +    QAction* zoomResetAction = m_actionCollection->addAction( QStringLiteral("view_zoom_reset") );
> +    zoomResetAction->setText(i18nc("@action:inmenu View", "Reset zoom level"));
> +    zoomResetAction->setWhatsThis(i18nc("@info:whatsthis zoom reset", "This resets the icon size to default."));

Sorry, I steered you wrong. The text needs to Use Title Case:

"Reset zoom level"

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22444

To: shubham, ngraham, elvisangelaccio
Cc: kfm-devel, kde-doc-english, aprcela, fprice, gennad, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, skadinna, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190715/fe56d079/attachment.htm>


More information about the kfm-devel mailing list