D21878: Rewrite servicemenu helper utility in C++

[Alexander Potashev]

aspotashev added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in servicemenuinstaller.cpp:35-42
> Since we are in a Qt program now, we could just open a KMessageBox rather than spawn another process just to show an error dialog (and `kdialog` might not even be installed).

I checked the sources of kdialog and discovered that what "kdialog --passivepopup" does is not trivial, see https://cgit.kde.org/kdialog.git/tree/src/kdialog.cpp#n517

Firstly it tries to show a Plasma/shell notification over D-Bus. If unavailable, it falls back to KPassivePopup.

In the //Beautiful// KNewStuff //of the Future//, we could pass the error message back to the "Get New Stuff" dialog and display it there as an inline notification. One of the ways to implement this would be a plugin system where Dolphin's servicemenuinstaller is a plugin (.so/.dll).

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D21878

To: aspotashev, sitter, elvisangelaccio, ngraham
Cc: cfeck, kfm-devel, aprcela, fprice, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190714/16893595/attachment.htm>