D21878: Rewrite servicemenu helper utility in C++

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> servicemenuinstaller.cpp:254
> +        QString installItPath;
> +        for (const auto &basename : QStringList{"install-it.sh", "install-it"}) {
> +            const auto path = findRecursive(dir, basename);

This will detach the container, please use qAsConst

> servicemenuinstaller.cpp:268
> +        QString installerPath;
> +        for (const auto &basename : QStringList{"installKDE4.sh", "installKDE4", "install.sh", "install"}) {
> +            const auto path = findRecursive(dir, basename);

This will detach the container, please use qAsConst

> servicemenuinstaller.cpp:302
> +        QString deinstallPath;
> +        for (const auto &basename : QStringList{"deinstall.sh", "deinstall"}) {
> +            const auto path = findRecursive(dir, basename);

This will detach the container, please use qAsConst

> servicemenuinstaller.cpp:319-320
> +            QString installerPath;
> +            for (const auto &basename : QStringList{"install-it.sh", "install-it", "installKDE4.sh",
> +                                                    "installKDE4", "install.sh", "install"}) {
> +                const auto path = findRecursive(dir, basename);

This will detach the container, please use qAsConst

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D21878

To: aspotashev, sitter, elvisangelaccio, ngraham
Cc: cfeck, kfm-devel, aprcela, fprice, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190714/5c72b852/attachment.htm>