D22386: Fix an issue with a new tab focus

Andrey Yashkin noreply at phabricator.kde.org
Wed Jul 10 19:16:04 BST 2019


AndreyYashkin created this revision.
AndreyYashkin added a project: Dolphin.
Herald added a subscriber: kfm-devel.
AndreyYashkin requested review of this revision.

REVISION SUMMARY
  When opening a new tab in the background and switching to that tab the focus is set on the location bar instead of the files view. If you switch back to the original tab and then to the new tab again focus will be set on the files view. The problem is caused by creation of //DolphinTabPage// in an active state which leads to skipping by //return// in //DolphinView::setActive(bool active)// without setting the focus on the view. This patch fixes this defect.
  
  BUG: 407604

TEST PLAN
  1. Open a new tab in the background
  2. Switch to the new tab
  3. Check current focus widget by the up/down arrows on the keyboard with and without changes.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D22386

AFFECTED FILES
  src/dolphintabpage.cpp

To: AndreyYashkin
Cc: kfm-devel, fprice, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190710/22ebccdb/attachment.htm>


More information about the kfm-devel mailing list