D22303: Fix name grouping feature for cyrillic names

Elvis Angelaccio noreply at phabricator.kde.org
Sun Jul 7 20:45:55 BST 2019


elvisangelaccio added a subscriber: cfeck.
elvisangelaccio added a comment.


  Thanks for the patch!
  
  Given that the correctness of this code depends on the locale, I'm not confident we won't break some corner cases. 
  Ideally we'd need more unit tests in `KFileItemModelTest::testNameRoleGroups()`, but I understand that's a lot to ask.
  
  @cfeck in the bug report suggested to add more letters ranges. @AndreyYashkin Did you try that?

REPOSITORY
  R318 Dolphin

BRANCH
  fix_for_bug_406867 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22303

To: AndreyYashkin, #dolphin, ngraham
Cc: cfeck, ngraham, elvisangelaccio, kfm-devel, fprice, fbampaloukas, alexde, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190707/7c70d855/attachment.htm>


More information about the kfm-devel mailing list