D18605: [versioncontrolobserver] Update working directory on tab activation
Elvis Angelaccio
noreply at phabricator.kde.org
Tue Jan 29 20:59:49 GMT 2019
elvisangelaccio added a comment.
I prefer your previous approach: an "observer" class is not supposed to have public slots, it should react on its own when stuff happens.
To avoid changing the constructor, we could add a new method `setView()`, similar to `setModel()` which we already have.
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D18605
To: anthonyfieroni, elvisangelaccio, #dolphin
Cc: kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190129/cb78084b/attachment.htm>
More information about the kfm-devel
mailing list