D17882: Abort updateWindowTitle and activeViewChanged if not changed.

[Chris Rizzitello]

rizzitello added a comment.


  In D17882#393661 <https://phabricator.kde.org/D17882#393661>, @anthonyfieroni wrote:
  
  > Searchbar propagates events even it's not visible, you can add check for visibility in focusin event.
  
  
  Well that got me looking again and I think this time I solved it correctly. 
  The DolphinTabPage::viewChanged code was emiting the change even if it was the same item, I changed the logic to return first also for this function. Testing with my test code in DolphinMainWindow::viewChanged I no longer got any duplicate refreshes on start or otherwise.  I tested with several tabs, search, filter and splits and by updating the directory in another program to see the dir updated in real time still.
  
  I Found one case where it was still generating the duplicate view and that is when you close a tab between two other tabs . I don't think its a problem since it seams to be the correct behavior for this case
  
  I'm Sorry to redo this yet again but this will be an overall better commit that solves the issue fully. Now . I will await your review.

REPOSITORY
  R318 Dolphin

BRANCH
  reduceRefreshCalls

REVISION DETAIL
  https://phabricator.kde.org/D17882

To: rizzitello, #dolphin, elvisangelaccio, broulik
Cc: anthonyfieroni, broulik, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190116/70cd7e65/attachment.htm>