D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in dolphinmainwindow.cpp:456
> Why another `if (!m_terminalPanel->isVisible())` block? Can't we merge this with the one above?

We actually can't--at least not cleanly. The top block modifies `standardButtons`, which is consumed later, the product of which (`buttons`) is needed in the second block.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10960

To: ngraham, #dolphin, elvisangelaccio, rominf
Cc: shubham, kfm-devel, elvisangelaccio, markg, ngraham, rkflx, broulik, #dolphin, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190113/3f9ef483/attachment.htm>