D17597: Use newly-upstreamed rename dialog from KIO

[Kai Uwe Broulik]

broulik added a comment.


  looks good

INLINE COMMENTS

> folderspanel.cpp:107
>      } else {
> -        RenameDialog* dialog = new RenameDialog(this, KFileItemList() << item);
> +        KIO::RenameFileDialog* dialog = new KIO::RenameFileDialog(this, KFileItemList() << item);
>          dialog->show();

Could also do `KFileItemList{item}`

> dolphinview.cpp:639
> +        KIO::RenameFileDialog* dialog = new KIO::RenameFileDialog(this, items);
> +        connect(dialog, SIGNAL(renamingFinished()), SLOT(slotRenameDialogRenamingFinished()));
>  

Why not keep the new connect syntax?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D17597

To: ngraham, #dolphin
Cc: broulik, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190110/ca2fe915/attachment.htm>