D18040: Close inactive split view when toggling off

Christoph Feck noreply at phabricator.kde.org
Wed Jan 9 00:55:05 GMT 2019


cfeck added inline comments.

INLINE COMMENTS

> cfeck wrote in dolphintabpage.cpp:103
>   if (...) {
>       ....
>   } else {
>      ....
>   }

Maybe in this case a ternary ` ? : ` is even more readable, but I am not sure of maintainers preference.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D18040

To: angeloevertonjr, ngraham, #dolphin
Cc: cfeck, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190109/1b1dca1a/attachment.htm>


More information about the kfm-devel mailing list