D18040: Close inactive split view when toggling off

Christoph Feck noreply at phabricator.kde.org
Wed Jan 9 00:52:50 GMT 2019


cfeck added inline comments.

INLINE COMMENTS

> behaviorsettingspage.cpp:104
> +    // 'Close focused view when turning off split view'
> +    m_closeFocusedSplitView = new QCheckBox(i18nc("option:check", "Close focused split view when toggling off"));
> +    topLayout->addRow(QString(), m_closeFocusedSplitView);

I guess we need to come up with a better description, "when toggling off" sounds confusing. Or could that just be removed, and a more verbose explanation added to a tooltip? Those are also accessible via Qt Accessibility.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D18040

To: angeloevertonjr, ngraham, #dolphin
Cc: cfeck, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190109/db3d40a6/attachment.htm>


More information about the kfm-devel mailing list