D18040: Close inactive split view when toggling off

[Nathaniel Graham]

ngraham added a reviewer: Dolphin.
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Thanks! I feel that implementing this is important. 312834 is one of the most common bug reports against Dolphin, with five duplicates and a //lot// of unhappy user comments. I think we should listen to our users and land this feature.
  
  I notice one issue that needs to be addressed before I feel comfortable making that recommendation though: Dolphin needs to update the conditions for when it changes the icon displayed in the button so that it accurately shows which view will be closed. This code is in`DolphinMainWindow::updateSplitAction()`

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D18040

To: angeloevertonjr, ngraham, #dolphin
Cc: kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190108/bccb2c2c/attachment.htm>