D17640: [versioncontrolobserver] Do not use static plugin objects

Anthony Fieroni noreply at phabricator.kde.org
Sat Jan 5 22:59:20 GMT 2019


anthonyfieroni updated this revision to Diff 48767.
anthonyfieroni added a comment.


  Apparently it has a problem, if 2 or more versioned tabs are open switching between does not update status/actions. It looks like in dolphin-plugin is used static object as well. So after all we don't want error in one tab to be multiplied to all opened, i've seen it often, since i'm using plugin daily, so easy fix is to update directory on tab activated, since observer has only private slots i'm using old syntax did you have better idea?

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17640?vs=48242&id=48767

REVISION DETAIL
  https://phabricator.kde.org/D17640

AFFECTED FILES
  src/views/dolphinview.cpp
  src/views/versioncontrol/versioncontrolobserver.cpp
  src/views/versioncontrol/versioncontrolobserver.h

To: anthonyfieroni, elvisangelaccio, dfaure, #dolphin
Cc: kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190105/7378d305/attachment.htm>


More information about the kfm-devel mailing list