D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering
Christoph Feck
noreply at phabricator.kde.org
Thu Feb 28 23:13:25 GMT 2019
cfeck added inline comments.
INLINE COMMENTS
> textcreator.cpp:169
> + syntaxHighlighter.setDefinition(m_highlightingRepository.definitionForFileName(path));
> + syntaxHighlighter.setTheme(m_highlightingRepository.defaultTheme(KSyntaxHighlighting::Repository::LightTheme));
> +
KSyntaxHighlighting::Theme also provides a background color. Can that be used instead of the hardcoded 245? I cannot remember reason why I disabled (or never enabled) the QPalette code; I suggest to remove it.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D19432
To: kossebau, broulik
Cc: cfeck, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190228/bcb96a5f/attachment.htm>
More information about the kfm-devel
mailing list