D18915: Fix batchrename changing extension to lower case

cfoster noreply at phabricator.kde.org
Wed Feb 27 22:42:25 GMT 2019


cfoster added inline comments.

INLINE COMMENTS

> bruns wrote in batchrenamejob.cpp:165
> I think you can use `QUrl::filename()`, and you should do it from the calling code.

Just making sure I understand you correctly.
Are you saying I should change the function to take the filename as a QString and extract the filename from the QUrl outside of the function or change url.toDisplayString() to url.fileName() within the function?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190227/385a50a3/attachment.htm>


More information about the kfm-devel mailing list