D19311: Add navigation history to forward/back buttons

[David Hallas]

hallas added a comment.


  I have a prototype working of this, what I did is essentially disable drawing of the drop down arrow for `QToolButton` in the Breeze theme. Do you guys know if this is a path forward? Should it be done conditional, and if so on what?
  This is the change i did in `breezestyle.cpp`
  
    diff --git a/kstyle/breezestyle.cpp b/kstyle/breezestyle.cpp
    index ed7d29b2..bcb7a788 100644
    --- a/kstyle/breezestyle.cpp
    +++ b/kstyle/breezestyle.cpp
    @@ -6068,11 +6068,11 @@ namespace Breeze
             // copy option and alter palette
             QStyleOptionToolButton copy( *toolButtonOption );
     
    -        const bool hasPopupMenu( toolButtonOption->features & QStyleOptionToolButton::MenuButtonPopup );
    -        const bool hasInlineIndicator(
    +        const bool hasPopupMenu(false/* toolButtonOption->features & QStyleOptionToolButton::MenuButtonPopup */);
    +        const bool hasInlineIndicator(false/*
                 toolButtonOption->features&QStyleOptionToolButton::HasMenu
                 && toolButtonOption->features&QStyleOptionToolButton::PopupDelay
    -            && !hasPopupMenu );
    +            && !hasPopupMenu */);
     
             const auto buttonRect( subControlRect( CC_ToolButton, option, SC_ToolButton, widget ) );
             const auto menuRect( subControlRect( CC_ToolButton, option, SC_ToolButtonMenu, widget ) );

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D19311

To: hallas, #dolphin, ngraham, elvisangelaccio, #vdg
Cc: abetts, kfm-devel, alexde, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20190227/941ab294/attachment.htm>